CLI: Fix onboarding not opening by ndelangen · Pull Request #33609 · storybookjs/storybook

ndelangen · 2026-01-21T10:26:04Z

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

Documentation
- Added clarifying comments about framework-specific command behavior.
Refactor
- Improved internal code structure for better maintainability.

Note: This release contains no user-facing changes. Updates are internal improvements only.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

nx-cloud · 2026-01-21T10:27:38Z

View your CI Pipeline Execution ↗ for commit 26dfe51

Command	Status	Duration	Result
`nx run-many -t compile,check,knip,test,pretty-d...`	✅ Succeeded	8m 23s	View ↗

☁️ Nx Cloud last updated this comment at 2026-01-21 10:38:48 UTC

…andling

coderabbitai · 2026-01-21T10:30:00Z

📝 Walkthrough

Walkthrough

Restructured flag-handling logic in runStorybookDev within initiate.ts, rebalancing conditional braces and adding a clarifying comment about Angular's ng run limitations. No functional behavior changes; updates are purely structural and documentation-focused within the conditional blocks.

Changes

Cohort / File(s)	Summary
Flag-handling restructuring in initiate `code/lib/create-storybook/src/initiate.ts`	Added clarifying comment on Angular's ng run flag limitations; rebalanced conditional braces in runStorybookDev's flag-handling block to ensure onboarding and quiet flags are applied only when supported

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

CLIInitiate: Simplify the CLI init port flag detection #33546: Modifies the same Angular special-case flag-handling logic in initiate.ts
Initiate: Fix used port flag handling #33544: Restructures conditional/brace layout and flag application in runStorybookDev's flag-handling block
CLI: Detect free port when running dev during initiate #33532: Adds port-detection and port-flag insertion to the same runStorybookDev logic

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

storybook-app-bot · 2026-01-21T10:38:03Z

Package Benchmarks

^{Commit: 26dfe51, ran on 21 January 2026 at 10:37:58 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/builder-webpack5`

	Before	After	Difference
Dependency count	192	192	0
Self size	75 KB	75 KB	🎉 -6 B 🎉
Dependency size	32.24 MB	32.25 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	49	49	0
Self size	20.30 MB	20.32 MB	🚨 +21 KB 🚨
Dependency size	16.52 MB	16.52 MB	🎉 -4 B 🎉
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	196	196	0
Self size	15 KB	15 KB	🚨 +12 B 🚨
Dependency size	28.96 MB	28.97 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	538	538	0
Self size	646 KB	646 KB	🎉 -10 B 🎉
Dependency size	59.22 MB	59.73 MB	🚨 +505 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs-vite`

	Before	After	Difference
Dependency count	127	127	0
Self size	1.12 MB	1.12 MB	🚨 +14 B 🚨
Dependency size	21.82 MB	22.32 MB	🚨 +496 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	159	159	0
Self size	30 KB	30 KB	🚨 +8 B 🚨
Dependency size	23.00 MB	23.61 MB	🚨 +610 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-vite`

	Before	After	Difference
Dependency count	117	117	0
Self size	35 KB	35 KB	🎉 -8 B 🎉
Dependency size	19.62 MB	20.11 MB	🚨 +496 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	278	278	0
Self size	24 KB	24 KB	🎉 -10 B 🎉
Dependency size	44.13 MB	44.64 MB	🚨 +505 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server-webpack5`

	Before	After	Difference
Dependency count	204	204	0
Self size	16 KB	16 KB	🎉 -10 B 🎉
Dependency size	33.49 MB	33.50 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	183	183	0
Self size	775 KB	775 KB	🚨 +219 B 🚨
Dependency size	67.38 MB	67.47 MB	🚨 +92 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	176	176	0
Self size	30 KB	30 KB	🎉 -4 B 🎉
Dependency size	65.95 MB	66.05 MB	🚨 +92 KB 🚨
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	50	50	0
Self size	1000 KB	999 KB	🎉 -50 B 🎉
Dependency size	36.82 MB	36.84 MB	🚨 +21 KB 🚨
Bundle Size Analyzer	node	node

`@storybook/preset-react-webpack`

	Before	After	Difference
Dependency count	170	170	0
Self size	18 KB	18 KB	🚨 +18 B 🚨
Dependency size	31.26 MB	31.28 MB	🚨 +11 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react`

	Before	After	Difference
Dependency count	57	57	0
Self size	732 KB	1.23 MB	🚨 +494 KB 🚨
Dependency size	12.94 MB	12.94 MB	🚨 +2 KB 🚨
Bundle Size Analyzer	Link	Link

…-added-parts CLI: Fix onboarding not opening (cherry picked from commit fb87f25)

Refactor port handling and onboarding logic in runStorybookDev function

a35dd08

ndelangen changed the title ~~Refactor port handling and onboarding logic in runStorybookDev function~~ CLI: Fix onboarding not opening Jan 21, 2026

ndelangen self-assigned this Jan 21, 2026

ndelangen added bug cli ci:normal Run our default set of CI jobs (choose this for most PRs). labels Jan 21, 2026

ndelangen marked this pull request as ready for review January 21, 2026 10:27

ndelangen requested a review from yannbf January 21, 2026 10:27

Update comments in runStorybookDev function to clarify Angular flag h…

26dfe51

…andling

yannbf approved these changes Jan 21, 2026

View reviewed changes

ndelangen merged commit fb87f25 into next Jan 21, 2026
124 checks passed

ndelangen deleted the norbert/fix-onboarding-cli-added-parts branch January 21, 2026 10:43

ndelangen added a commit that referenced this pull request Jan 21, 2026

Merge pull request #33609 from storybookjs/norbert/fix-onboarding-cli…

1d3834a

…-added-parts CLI: Fix onboarding not opening (cherry picked from commit fb87f25)

This was referenced Jan 21, 2026

Release: Prerelease 10.2.1-0 #33612

Closed

Release: Preminor alpha 10.3.0-alpha.0 #33613

Merged

anovelbot-dependencies Bot mentioned this pull request Mar 18, 2026

chore(deps): update dependency eslint-plugin-storybook to v10.3.0 a-novel/service-json-keys#430

Merged

1 task

anovelbot-dependencies Bot mentioned this pull request Mar 18, 2026

chore(deps): update dependency eslint-plugin-storybook to v10.3.0 a-novel/service-template#38

Merged

1 task

anovelbot-dependencies Bot mentioned this pull request Mar 18, 2026

chore(deps): update dependency eslint-plugin-storybook to v10.3.0 a-novel/service-authentication#674

Merged

1 task

This was referenced Mar 18, 2026

Update dependency @storybook/cli to v10 FineArchs/MFM-MOJI#275

Open

Update dependency eslint-plugin-storybook to v10 FineArchs/MFM-MOJI#277

Open

This was referenced May 3, 2026

chore(deps): update storybook monorepo to v10 berlysia/berlysia.net#528

Open

Update storybook monorepo to v10 - autoclosed RedHatInsights/nxtcm-components#203

Closed

Update storybook monorepo to v10.3.6 (master) morewings/react-library-template#464

Merged

cultureamp-renovate Bot mentioned this pull request May 8, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6671

Closed

1 task

cultureamp-renovate Bot mentioned this pull request May 15, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6697

Closed

1 task

This was referenced May 16, 2026

chore(deps): update storybook monorepo to v10 movahedan/monobun#282

Merged

Update dependency storybook to v10 nationalarchives/ds-caselaw-public-ui#3158

Closed

cultureamp-renovate Bot mentioned this pull request May 22, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6724

Closed

1 task

cultureamp-renovate Bot mentioned this pull request May 29, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6749

Closed

1 task

renovate Bot mentioned this pull request Jun 11, 2026

chore(deps): update storybook monorepo to v10 giantswarm/happa#4835

Open

1 task

cultureamp-renovate Bot mentioned this pull request Jun 12, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6791

Closed

1 task

matticbot mentioned this pull request Jun 13, 2026

chore(deps): update storybook monorepo to v10 (major) Automattic/wp-calypso#111639

Open

1 task

renovate Bot mentioned this pull request Jun 15, 2026

Update Next.js HHS/simpler-grants-gov#10929

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CLI: Fix onboarding not opening#33609

CLI: Fix onboarding not opening#33609
ndelangen merged 2 commits into
nextfrom
norbert/fix-onboarding-cli-added-parts

ndelangen commented Jan 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jan 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

storybook-app-bot Bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ndelangen commented Jan 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

storybook-app-bot Bot commented Jan 21, 2026

Package Benchmarks

@storybook/builder-webpack5

storybook

@storybook/ember

@storybook/nextjs

@storybook/nextjs-vite

@storybook/react-native-web-vite

@storybook/react-vite

@storybook/react-webpack5

@storybook/server-webpack5

@storybook/cli

@storybook/codemod

create-storybook

@storybook/preset-react-webpack

@storybook/react

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ndelangen commented Jan 21, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Jan 21, 2026 •

edited

Loading

coderabbitai Bot commented Jan 21, 2026 •

edited

Loading

`@storybook/builder-webpack5`

`storybook`

`@storybook/ember`

`@storybook/nextjs`

`@storybook/nextjs-vite`

`@storybook/react-native-web-vite`

`@storybook/react-vite`

`@storybook/react-webpack5`

`@storybook/server-webpack5`

`@storybook/cli`

`@storybook/codemod`

`create-storybook`

`@storybook/preset-react-webpack`

`@storybook/react`